Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48849 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags ......................................................................
mb/ocp/deltalake: Override SMBIOS type 2 feature flags
Override SMBIOS type 2 board feature flags. For Delta Lake, board is replaceable and is a hosting board.
Tested=Execute "dmidecode -t 2" to check info is correct.
Signed-off-by: Tim Chu Tim.Chu@quantatw.com Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48849 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com --- M src/include/smbios.h M src/mainboard/ocp/deltalake/ramstage.c 2 files changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Jonathan Zhang: Looks good to me, approved
diff --git a/src/include/smbios.h b/src/include/smbios.h index 78f364e..694e091 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -311,6 +311,12 @@ u8 eos[2]; } __packed;
+#define SMBIOS_FEATURE_FLAGS_HOSTING_BOARD (1 << 0) +#define SMBIOS_FEATURE_FLAGS_REQUIRES_DAUGHTER_CARD (1 << 1) +#define SMBIOS_FEATURE_FLAGS_REMOVABLE (1 << 2) +#define SMBIOS_FEATURE_FLAGS_REPLACEABLE (1 << 3) +#define SMBIOS_FEATURE_FLAGS_HOT_SWAPPABLE (1 << 4) + typedef enum { SMBIOS_BOARD_TYPE_UNKNOWN = 0x01, SMBIOS_BOARD_TYPE_OTHER = 0x02, diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 7c79949..211ba0f 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -56,6 +56,12 @@ return slot_id_str; }
+/* Override SMBIOS type 2 Feature Flags */ +u8 smbios_mainboard_feature_flags(void) +{ + return SMBIOS_FEATURE_FLAGS_HOSTING_BOARD | SMBIOS_FEATURE_FLAGS_REPLACEABLE; +} + /* * Override SMBIOS type 4 cpu voltage. * BIT7 will set to 1 after value return. If BIT7 is set to 1, the remaining seven