[coreboot-gerrit] [S] Change in coreboot[master]: acpi/acpi.h: Move acpi_addr64_t to GAS section

[Angel Pons (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Held.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77500?usp=email )

Change subject: acpi/acpi.h: Move acpi_addr64_t to GAS section
......................................................................

Patch Set 1:

(1 comment)

File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/77500/comment/b94b012a_4f489c38 :
PS1, Line 113: 	u64 addr;               /* Register address */
> wouldn't it be better to only have acpi_gen_regaddr, but have it contain a union of u32 addrl & u32  […]

Question is, can there be endianness issues? It would seem that big-endian platforms can end up with swapped low/high DWORDs when using unions.

If not, +1 to:
```
union {
    struct {
    	u32 addrl;
    	u32 addrh;
    };
    u64 addr;
};
```

Should work when placed inside a struct. Haswell NRI register definitions are like this, but the union is named and the inner struct uses bitfields.