Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69386/comment/8fc396ba_4e69afe4 PS2, Line 14: https://www.marvell.com/content/dam/marvell/en/public-collateral/phys-transc...
I have pushed this datasheet to archive.org: […]
Done
File src/drivers/phy/m88e1512/chip.h:
https://review.coreboot.org/c/coreboot/+/69386/comment/aa39eb87_0cbd9544 PS2, Line 6: led_customize
Maybe 'configure_leds' instead? And since this is just a flag, should it be bool then?
Done
https://review.coreboot.org/c/coreboot/+/69386/comment/b34af7ce_9c311cb5 PS2, Line 7: led_ctrl
The LED control register includes a LED[2] control field as well. […]
something like that?
File src/drivers/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/f571c744_5b98a91c PS2, Line 17: dev->bus->dev
To increase readability a dedicated device pointer (something like parent or similar) would be helpf […]
Done
https://review.coreboot.org/c/coreboot/+/69386/comment/3acc0ab5_42739665 PS2, Line 35: Select page back to 0.
'Switch back to page 0. […]
Done