Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper
......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33116/21/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33116/21/src/Kconfig@259
PS21, Line 259: config USE_EXTERNAL_STAGE_CACHE
I would call this simply 'TSEG_STAGE_CACHE' if that reflects accurately what we currently have.
https://review.coreboot.org/c/coreboot/+/33116/21/src/Kconfig@268
PS21, Line 268: config USE_CBMEM_STAGE_CACHE
Just 'CBMEM_STAGE_CACHE'. At least I find the prefix 'USE_' just useless.
https://review.coreboot.org/c/coreboot/+/33116/21/src/cpu/intel/smm/gen1/smm...
File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/33116/21/src/cpu/intel/smm/gen1/smm...
PS21, Line 124: if (CONFIG(USE_EXTERNAL_STAGE_CACHE)) {
i guess USE_EXTERNAL_STAGE_CACHE kconfig has detailed help to know where it might like to store the […]
The conditional here needs to evaluate true with TSEG only. From what I remember, all external stage caches are currently TSEG.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 21
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 06:36:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment