[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Initialize display

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )

Change subject: mb/google/kukui: Initialize display
......................................................................

Patch Set 28:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32511/19/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/display.c:

https://review.coreboot.org/c/coreboot/+/32511/19/src/mainboard/google/kukui... 
PS19, Line 61: static struct edid *get_edid(struct board_display_intf *intf)
             : {
             : 	struct panel_info *info = intf->cur_panel_info;
             : 
             : 	if (info)
             : 		return info->edid;
             : 	return NULL;
             : }
> I think this function is not needed since it's only called one time, and the intf is provided by dev […]

Ack

https://review.coreboot.org/c/coreboot/+/32511/19/src/mainboard/google/kukui... 
PS19, Line 84: get_panel_name
> this is also not needed...

Ack

https://review.coreboot.org/c/coreboot/+/32511/19/src/mainboard/google/kukui... 
PS19, Line 100: update_panel_info
> In fact we don't need to call intf->get_panel_id. […]

Ack