Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34740 )
Change subject: intel/smm/gen1: Use smm_subregion()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34740/1/src/cpu/intel/smm/gen1/smmr...
File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/34740/1/src/cpu/intel/smm/gen1/smmr...
PS1, Line 129:
Those setups are not wrong, per se. […]
CB:34776 puts an early assert.
IMHO we cannot just leave SMRR unprogrammed and continue. Weird cases whether SMI handler gets locked or not, or whether even SMI can access TSEG.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I371ed41f485b3143e47f091681198d6674928897
Gerrit-Change-Number: 34740
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 09:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment