[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp: Move function debug macros

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46093 )

Change subject: soc/intel/xeon_sp: Move function debug macros
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46093/5/src/include/device/device.h 
File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/46093/5/src/include/device/device.h... 
PS5, Line 282: #if CONFIG(DEBUG_FUNC)
> Sorry for going back and forth so much... […]

This is some pretty generic stuff. Ron wanted to add "poor man's debugging" to the core code many times. I don't see how this is "extending the scope of these macros". I do not see it as beneficial to bury this stuff behind yet another config variable when we already have 10x more config variables than are possibly needed to build a firmware image. This "fake choice" just litters up the code base imo.