Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32912 )
Change subject: soc/intel/quark: Remove variable set but not used
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c
File src/soc/intel/quark/i2c.c:
https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c@a132
PS5, Line 132:
it's possible that this line exists to force a read on the data_cmd register. regs is of type I2C_REGS which is a volatile struct. Replace "junk = (uint8_t)" with "(void)" and we're good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09292c2776309982cfb4d72012991bf7725b75fb
Gerrit-Change-Number: 32912
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Fri, 21 Jun 2019 09:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment