Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44917 )
Change subject: soc/intel/tigerlake: Enable and use USB4 PCIe driver ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44917/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/44917/3/src/soc/intel/tigerlake/chi... PS3, Line 8: chip drivers/intel/usb4/pcie : register "port_id" = "0" : use tbt_dma0 as usb4_port : device pci 07.0 alias tbt_pcie_rp0 off end : end
I think we should avoid the mistake we did with CNVi device and instead use a virtual generic device […]
The driver will need to have pci ops and *_resource handlers for an attached pci device to get properly set up. as long as the driver is set up for pci it should work even if the child is declared as generic in devicetree, but we should probably be clear what is attached to the root port and make this 'device pci 00.0 on end'