Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45696 )
Change subject: mb/purism/librem_whl: Drop 3Gbps SATA limit; enable and set SATA tuning params ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45696/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/romstage.c:
https://review.coreboot.org/c/coreboot/+/45696/1/src/mainboard/purism/librem... PS1, Line 58: mem_cfg->PchSataHsioRxGen3EqBoostMag[2] = 1;
IIRC one of these two ports is on a cable. As per guidelines, I think it should be 2 or 3 instead. […]
Done