Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30732 )
Change subject: AGESA: Drop CONFIG_CBB and CONFIG_CDB
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30732/2/src/northbridge/amd/agesa/family12/a...
File src/northbridge/amd/agesa/family12/amdfam12_conf.c:
https://review.coreboot.org/#/c/30732/2/src/northbridge/amd/agesa/family12/a...
PS2, Line 17: * No includes in this file because it is included into northbridge.c.
I hate comments :-P
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07bc046c74280f49e46793c119d36b87b8789949
Gerrit-Change-Number: 30732
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 16:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment