Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37282 )
Change subject: soc/intel/common: Rename functions to have consistency naming ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... PS4, Line 297:
Done
Done
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... PS4, Line 144: BIOS_HOST_ADDR
It's a value of Host_Address field of Fixed Address MEI Header. So, macro rename is not required.
Done
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... PS4, Line 147: /* Command GLOBAL_RESET_REQ Reset Types */ : #define GLOBAL_RESET 1 : #define HOST_RESET_ONLY 2 : #define CSE_RESET_ONLY 3
The comment is addressed in the patch : https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/37282/4/src/soc/intel/common/block/... PS4, Line 152: *
Addressed the change in in the https://review.coreboot. […]
Done