Attention is currently required from: Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70041 )
Change subject: arch/x86: Add bitwise operations for IO space
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70041/comment/e469f19a_31bad805
PS1, Line 8:
You could mention that: […]
Yeah, let's keep this on hold, improve the message, and only submit once the actual use cases are ready for submission too.
I think I will want to add some sort of is_set(PM_REGISTER, bit) style conditional.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e1146f062dced1b75195846ea65a44e2bd4482
Gerrit-Change-Number: 70041
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 27 Nov 2022 20:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment