Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44187 )
Change subject: soc/intel/common/cse_lite: Perform a board specific reset
......................................................................
Patch Set 4:
Patch Set 3:
Patch Set 3:
Actually I thought of something, if the `cse_board_reset` callback is unable to actually reset the system (because sending the EC a command may fail), then it might be better to leave the `do_global_reset` where it was before, so if the EC fails to reset the system, it would drop down into the call to `do_global_reset`, and it would at least boot into recovery mode (b/c of TPM re-init failure), instead of just hanging here.
WDYT?
I agree to that. Also if the TPM is not hosting old firmware, then cse_board_reset can be a no-op and global reset can be performed.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8663e7f25461e58e45766e2ac00d752bfa191d8b
Gerrit-Change-Number: 44187
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 22:08:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment