Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use calibration result do fast calibration ......................................................................
Patch Set 12:
(1 comment)
below data tested under no DRAM calibration debug log full calibration clock 800 using 1434 msecs clock 1600 using 1032 msecs clock 1866 using 1384 msecs Total:3850 ms
partital calibration K finish with clock:800 mem init time of freq_shuffle:2, using 1349385 usecs K finish with clock:1600 mem init time of freq_shuffle:1, using 924698 usecs K finish with clock:1866 mem init time of freq_shuffle:0, using 1270089 usecs Total:3544172 usecs
fast calibration K finish with clock:800 mem init time of freq_shuffle:2, using 216663 usecs K finish with clock:1600 mem init time of freq_shuffle:1, using 328220 usecs K finish with clock:1866 mem init time of freq_shuffle:0, using 322612 usecs Total:867495 usecs
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/em... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/em... PS12, Line 71: return false;
Use ternary operator? Or even better, directly return: […]
Done