Attention is currently required from: Nico Huber, Paul Menzel, Maximilian Brune.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory map ......................................................................
Patch Set 7:
(5 comments)
File util/cbfstool/cbfstool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164290): https://review.coreboot.org/c/coreboot/+/68160/comment/d6076b51_b6c1be10 PS7, Line 395: * Default decode window lives just below 4G boundary in host space and maps up to a line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164290): https://review.coreboot.org/c/coreboot/+/68160/comment/13f5e068_ce3b1cbf PS7, Line 396: * maximum of 16MiB. If the window is smaller than 16MiB, the SPI flash window is mapped line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164290): https://review.coreboot.org/c/coreboot/+/68160/comment/50e2ef04_ed2c546b PS7, Line 399: add_mmap_window(std_window_flash_offset, DEFAULT_DECODE_WINDOW_TOP - std_window_size, std_window_size); line length of 119 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164290): https://review.coreboot.org/c/coreboot/+/68160/comment/862f2b66_37582262 PS7, Line 408: ERROR("Flash space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164290): https://review.coreboot.org/c/coreboot/+/68160/comment/5e86302b_6ed26707 PS7, Line 418: ERROR("Host space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 134 exceeds 96 columns