[coreboot-gerrit] Change in coreboot[master]: src/arch/x86:Add support for low power idle table

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )

Change subject: src/arch/x86:Add support for low power idle table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1253 
PS4, Line 1253: __weak void soc_residency_counter(struct acpi_lpit_native *lpit_native)
> just having one LPIT entry isn't enough; to make linux use both sysfs interfaces, there need to be t […]

hmm, maybe I was wrong and we don't even need soc-specific LPIT tables but just set the addresses and MSRs via macros/defines? That way we can avoid ugly call-backs. That's more or less what platform sample code for KBL and TGL does.

Tim, what do you think?