[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 13:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39002/6/src/include/edid.h 
File src/include/edid.h:

https://review.coreboot.org/c/coreboot/+/39002/6/src/include/edid.h@107 
PS6, Line 107: struct fb_info;
> > `framebuffer_info. […]

Done

https://review.coreboot.org/c/coreboot/+/39002/11/src/include/framebuffer_in... 
File src/include/framebuffer_info.h:

https://review.coreboot.org/c/coreboot/+/39002/11/src/include/framebuffer_in... 
PS11, Line 35: static
> Is there a good reason this is an inline? It's not *that* small...

Moved out of this commit and reduced it'S size.

https://review.coreboot.org/c/coreboot/+/39002/11/src/include/framebuffer_in... 
PS11, Line 39: DIV_ROUND_UP(bpp, 8) / 8
> 24bpp is a valid pixel format. […]

Started cleaning up the 24bpp mess here: CB:40798
It requires test on all drivers as I can't determine the correct mapping from the source.
Marking this as resolved for now.

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@36 
PS7, Line 36: static struct fb_info list;
> It ended in CB:39005 while rebasing, will fix that.

Done