[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add display driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )

Change subject: mediatek/mt8183: Add display driver
......................................................................

Patch Set 11:

(2 comments)

The build failure is caused by ATF include files. Can you rebase this to ToT instead of ATF? Then we may review and merge display changes earlier.

https://review.coreboot.org/#/c/31478/11/src/soc/mediatek/mt8183/include/soc... 
File src/soc/mediatek/mt8183/include/soc/ddp.h:

https://review.coreboot.org/#/c/31478/11/src/soc/mediatek/mt8183/include/soc... 
PS11, Line 4: 2015
2019

https://review.coreboot.org/#/c/31478/11/src/soc/mediatek/mt8183/include/soc... 
PS11, Line 58: /* DISP_REG_CONFIG_MMSYS_CG_CON0
             :    Configures free-run clock gating 0
             : 	0: Enable clock
             : 	1: Clock gating  */
/*
 * DISP_REG_CONFIG_MMSYS_CG_CON0
 * Configure free-run clock gating 0
 *   0: Enable clock
 *   1: Clock gating
 */