Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37753 )
Change subject: lib/crc_byte: Add CRC32 implementation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37753/1/src/include/crc_byte.h
File src/include/crc_byte.h:
https://review.coreboot.org/c/coreboot/+/37753/1/src/include/crc_byte.h@52
PS1, Line 52: ~0;
Why the negation here and for the result? Does it not work when you just start with 0? If so, do we […]
That's described in ITU I.363.5 /ITU V.42.
Starting with 0 is also possible, but would give different results.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If98e4e12bb53a6e5123e94e8cdffde1eb3bc4b4b
Gerrit-Change-Number: 37753
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Dec 2019 06:49:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment