Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40286 )
Change subject: drivers/ipmi: Implement the function for logging system events into BMC
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40286/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40286/5//COMMIT_MSG@9
PS5, Line 9: Implemented for functions that need to log system event into BMC, the information of system event can be specific.
Please wrap the line after 72 characters.
Done
https://review.coreboot.org/c/coreboot/+/40286/5//COMMIT_MSG@9
PS5, Line 9: event
events
Done
https://review.coreboot.org/c/coreboot/+/40286/5//COMMIT_MSG@11
PS5, Line 11: TEST=Use ipmitool to check if SEL is added into BMC.
Paste the exact command?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f3acb958d12c196d33d34fd5cfa0b784f403b7
Gerrit-Change-Number: 40286
Gerrit-PatchSet: 7
Gerrit-Owner: Morgan Jang
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 10 Apr 2020 10:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment