Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48355 )
Change subject: device/azalia_device.c: Add codec reset helpers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48355/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48355/3//COMMIT_MSG@9 PS3, Line 9: Many uses of `azalia_set_bits` are used to toggle the reset bit. They : will be put to use in subsequent commits, one change per function. :
maybe simply describe what you do here? […]
Sorry, I don't understand what exactly is wrong with this commit message (the summary is also part of the commit message, btw). I use the summary to state what this change does, and then explain why I'm doing it as well as what I want this for. I'm not going to repeat the summary in the commit message, because it is redundant.