Attention is currently required from: Joel Bueno, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/86588?usp=email )
Change subject: soc/riscv/ucb: Switch to FDT parsing to get memory size ......................................................................
Patch Set 2:
(7 comments)
File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/86588/comment/d52def5b_a11d46c8?usp... : PS2, Line 12: uint64_t top;
`code indent should use tabs where possible`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/55f439bf_3bde8797?usp... : PS2, Line 12: uint64_t top;
`please, no spaces at the start of a line`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/22b68e9a_e684160f?usp... : PS2, Line 14: top = fdt_get_memory_top((void *)HLS()->fdt);
`code indent should use tabs where possible`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/40de7a69_1251d670?usp... : PS2, Line 15: ASSERT_MSG(top, "Failed reading memory range from FDT");
`code indent should use tabs where possible`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/b9f4aca4_7544cd74?usp... : PS2, Line 15: ASSERT_MSG(top, "Failed reading memory range from FDT");
`please, no spaces at the start of a line`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/df27600a_b389ef33?usp... : PS2, Line 17: return MIN(top, (uint64_t)4 * GiB - 1);
`please, no spaces at the start of a line`
Please fix.
https://review.coreboot.org/c/coreboot/+/86588/comment/4cc090f2_555ab8e4?usp... : PS2, Line 17: return MIN(top, (uint64_t)4 * GiB - 1);
`code indent should use tabs where possible`
Please fix.