Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42028 )
Change subject: The .config is overwritten when added to coreboot.rom via CBFS at the end of the build (if you choose that option)... should this be a separate file for each of fallback and normal? Since there can be two different versions and/or configurations, would fallback/config and normal/config make more sense? Also the "revision" file might benefit from similar treatment. ......................................................................
Patch Set 1:
Nice. Welcome to coreboot and thank you for the patch.
It’d be great if you could amend the git commit message to follow the common style.
$ git commit --amend $ git push
… should be all you need.
[1]: https://doc.coreboot.org/tutorial/part2.html#step-4a-use-the-command-line-to... [2]: https://chris.beams.io/posts/git-commit/