SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37911 )
Change subject: mb/google/kohaku: Update reset_delay_ms for digitizer device
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37911/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37911/3//COMMIT_MSG@14
PS3, Line 14: It seems the IC need some time before communication
: after de-assertion of reset.
Just guessing from our experiment. Without reset_delay, driver get failed to bind always. […]
Done
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/...
PS1, Line 213: post-power-on-delay-ms
Please review the new patch set.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb33c13c9a390a2c971325c74c0c4ad4b08618e
Gerrit-Change-Number: 37911
Gerrit-PatchSet: 5
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 27 Dec 2019 02:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: shkim
sh_.kim@samsung.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment