Attention is currently required from: David Wu, Rory Liu, Zhuohao Lee, Alan Huang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 )
Change subject: drivers/net/r8168: Add support for Realtek RT8125
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/a930978b_552d3c5b
PS7, Line 9: The Realtek RT8168 and RT8125 have a similar programming
: interface, therefore add the PCI device ID for the RT8125
: into driver for support.
Please reflow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/59086/comment/e0333298_48c6f60b
PS7, Line 14: TEST=emerge-brask coreboot chromeos-bootimage
On what device? What didn’t work before, and what works now?
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/59086/comment/1d389fc8_3c696cf0
PS7, Line 1287: #define PCI_DEVICE_ID_REALTEK_8125 0x8125
Please sort them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4c41f94fd6e5fd6393abbb30bfc22a149f5d71
Gerrit-Change-Number: 59086
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 22:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment