Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46303 )
Change subject: drivers/soundwire/alc711: Add Realtek ALC711 soundwire device ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/46303/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46303/1//COMMIT_MSG@7 PS1, Line 7: Add RT711 s
please use same in code and here: either RT711 or ALC711
Done
https://review.coreboot.org/c/coreboot/+/46303/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46303/3//COMMIT_MSG@7 PS3, Line 7: drivers/soundwire/alc711 : Add Realtek ALC711 soundwire device
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/46303/3/src/drivers/soundwire/alc71... File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/46303/3/src/drivers/soundwire/alc71... PS3, Line 40: 9600 * KHz, 4800 * KHz, 2400 * KHz, 1200 * KHz, /* 9.6 MHz */
Add the space before the 9600?
i used the format from other patchsets ex. https://review.coreboot.org/c/coreboot/+/40890 can we retain it this way ?
https://review.coreboot.org/c/coreboot/+/46303/3/src/drivers/soundwire/alc71... PS3, Line 80:
Please remove the blank line.
Done
https://review.coreboot.org/c/coreboot/+/46303/3/src/drivers/soundwire/alc71... PS3, Line 86:
Please remove the blank line.
Done