Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180
PS7, Line 180: and any other native display initialization code is not run
Sorry, I forgot to mention, I had Haswell in mind. […]
Yeah, I just added that there recently... why did I do that? Oh, because we used to set it in depthcharge for Haswell when the option was still there. Hmmm. Quite possible that this no longer applies nowadays. Did all the Haswell boards switch to libgfxinit? If so, we can probably remove this there. (Then again, nobody really cares...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf111a533c3953448b4b9084885a9a65a2432a8b
Gerrit-Change-Number: 32262
Gerrit-PatchSet: 7
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Randall Spangler
rspangler@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 26 Apr 2019 06:16:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
