Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries ......................................................................
Patch Set 2:
Another thought, if we want to get rid of this legacy, x86 location, but keep the id, how about adding a simple file to CBFS as standard from now on, and keeping the legacy id in the bootblock for a few releases until users adapted?
That's also my preferred option. (I would be fine with keeping the old .id in parallel for a bit longer too, but I don't know if Furquan had any specific pressure to get rid of it right now.)
From an academic viewpoint, I would probably put the version into the CBFS header and board/vendor into the FMAP header ;) Not sure how feasible that is.
If you actually mean header, I don't think there's any space for those kind of things in there, and I don't think we'd want to mess with these well-established structures.
Looking at a current CBFS, we already have a `revision` file... which is not very machine readable, though. And what is still missing is the board/vendor id, but that really shouldn't differ between multiple CBFS's inside a single image.
Yeah, it would probably make sense to either merge this into the revision file or supersede that file with whatever new format that contains all that info we'd make up.