Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39345/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39345/8/src/mainboard/google/voltee... PS8, Line 168: 60
I think that's good reference based on board SKU id. […]
i'm actually hoping to avoid decoding the board SKU ID as there are going to be many combinations or encodings.
is there an intel CPU id we can use? looking at soc/intel/tigerlake/bootblock/report_platform.c maybe mchid can be use?
mch_table[] = { { PCI_DEVICE_ID_INTEL_TGL_ID_U, "Tigerlake-U-4-2" }, { PCI_DEVICE_ID_INTEL_TGL_ID_U_1, "Tigerlake-U-4-3e" }, { PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2, "Tigerlake-U-2-2" }, { PCI_DEVICE_ID_INTEL_TGL_ID_Y, "Tigerlake-Y-4-2" }, { PCI_DEVICE_ID_INTEL_JSL_ID_1, "Jasperlake-1" }, { PCI_DEVICE_ID_INTEL_JSL_EHL, "Jasperlake Elkhartlake" }, { PCI_DEVICE_ID_INTEL_EHL_ID_1, "Elkhartlake-1" }, };
do these two map to 4c vs 2c? Tigerlake-U-4-2 Tigerlake-U-2-2