Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: tigerlake/apci: Only use SCM for ChromeOS ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58798/comment/621f8efc_050c5282 PS5, Line 9: SCM doesn't work with Linux 5.13 or later and results in TBT : ports timing out. Not advertising this results in FCM being used : and TBT works correctly.
Not sure if everyone knows what SCM/FCM mean, maybe spell them out once?
Done
Patchset:
PS5:
Nice digging Sean!
Unfortunately, this has turned out to be Part 1 of 2 as D3cold is refusing to turn off. Fun times 😊
File 3rdparty/blobs:
PS1:
I think this was unintentional, try […]
Done
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/58798/comment/67d0f405_a7a17587 PS1, Line 136: #if CONFIG(CHROMEOS)
23A0D13A-26AB-486C-9C5F-0FFA525A575A […]
Done
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/58798/comment/31d79905_dcd6e89e PS5, Line 157: #if CONFIG(CHROMEOS)
Can you add a comment here (similar to your commit msg) why this is done?
Done