Attention is currently required from: John Su, Jason Nien, Chris Wang, Martin Roth, Karthik Ramasubramanian, Patrick Huang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74133 )
Change subject: mb/google/skyrim: override Markarth PCIe config
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74133/comment/bba478e1_d06efa32
PS3, Line 7: mb/google/skyrim
Shouldn’t variant names be mentioned in the prefix?
https://review.coreboot.org/c/coreboot/+/74133/comment/09b14e21_bdf2f689
PS3, Line 8:
I’d start by describing the problem. Do you have a non-working test device? Or did you just check the schematics?
https://review.coreboot.org/c/coreboot/+/74133/comment/3285033b_399edf22
PS3, Line 9: We
lowercase: we
https://review.coreboot.org/c/coreboot/+/74133/comment/30bd1920_adadac36
PS3, Line 12: allows
allowing
https://review.coreboot.org/c/coreboot/+/74133/comment/8cce2c22_83961b59
PS3, Line 17: TEST=emerge-skyrim coreboot chromeos-bootimage
Did you test this on a real device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b4e4067a30019d742c7589a52badf93b7091615
Gerrit-Change-Number: 74133
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 11:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment