[coreboot-gerrit] [M] Change in coreboot[main]: security/intel/txt: Verify Intel TXT required TPM2 indices presence

[Filip Lewiński (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Singer, Julius Werner, Krystian Hebel, Martin Roth, Michał Kopeć, Michał Żygowski, Yu-Ping Wu.

Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82417?usp=email )

Change subject: security/intel/txt: Verify Intel TXT required TPM2 indices presence
......................................................................

Patch Set 12:

(3 comments)

File src/security/intel/txt/common.c:

https://review.coreboot.org/c/coreboot/+/82417/comment/d0c02c1a_558dc560?usp... :
PS11, Line 14: #include <security/tpm/tss.h>
> Keep includes ordered alphabetically.

[Moved](https://review.coreboot.org/c/coreboot/+/82417/11..12/src/security/intel/txt...)

https://review.coreboot.org/c/coreboot/+/82417/comment/9af1be47_d7cd392a?usp... :
PS11, Line 426: 	/* The index could have been written already, but we don't need to care. */
> Can it _not_ be written? Further code compares it against known value, so it must have a content.

[Removed](https://review.coreboot.org/c/coreboot/+/82417/11..12/src/security/intel/txt...)

https://review.coreboot.org/c/coreboot/+/82417/comment/2d202e4a_2fa06550?usp... :
PS11, Line 458: 	/* The index could have been written already, but we don't need to care. */
> Same as above.

[Removed](https://review.coreboot.org/c/coreboot/+/82417/11..12/src/security/intel/txt...), as above