Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/86336/comment/1f4aeb54_786935af?usp... : PS3, Line 635: __weak void platform_do_early_poweroff(void)
I appreciate your suggestion @th3fanbus@gmail. […]
I agree with Jérémy on the first item: the whole point of making this function `__weak` is that `google/chromeec/ec.c` could directly override it, so that we don't need to add code that calls a Google-specific function directly to this common Intel PMC driver. I think it's fine if the Google ChromeEC code implements a function called `platform_do_early_poweroff()`. That name doesn't say anything about Intel, it's generic enough that if other platforms would have a need for the same functionality they could use the same function.
(I don't know about whether it makes sense to call the PMC function in the fallback case or just do `halt()` directly, I'll let you guys argue about that.)