Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39849 )
Change subject: [WIP] Add a voltage parameter for getting info from USB PD
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39849/1/src/mainboard/google/fizz/m...
File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39849/1/src/mainboard/google/fizz/m...
PS1, Line 118: mini_volts
What is *mini*? Minimum? I know of *min* and *max* as common abbreviations.
sorry, it's milliVolts, will modify it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11efe6f45f2f929fcb2763d192268e677d7426cb
Gerrit-Change-Number: 39849
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Harry Pan
harry.pan@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 17:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment