18 Dec
2021
18 Dec
'21
12:37 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41272 )
Change subject: soc/amd/common/block: Add support for configuring eSPI connection to slave ......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS7: ddre
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/41272/comment/04aba741_895881fd PS6, Line 423: check
from this part of the function name I wouldn't expect it to poll SLAVE0_INT_STS to become non-zero
addressed in CB:44354
https://review.coreboot.org/c/coreboot/+/41272/comment/c0978cb5_aa8d070c PS6, Line 487:
maybe add an "unexpected" here?
addressed in CB:44352
--
To view, visit https://review.coreboot.org/c/coreboot/+/41272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I872ec09cd92e9bb53f22e38d2773f3491355279e
Gerrit-Change-Number: 41272
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 18 Dec 2021 00:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment