Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40141 )
Change subject: [TEST] Kill the dead_code macro
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40141/2/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/40141/2/src/lib/string.c@a11
PS2, Line 11: /* This can't be used without malloc(). */
Keep this comment
Done
https://review.coreboot.org/c/coreboot/+/40141/2/src/soc/intel/braswell/pmut...
File src/soc/intel/braswell/pmutil.c:
https://review.coreboot.org/c/coreboot/+/40141/2/src/soc/intel/braswell/pmut...
PS2, Line 365: /* not usable in ramstage as GEN_PMCON1 gets reset */
Keep this comment
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f825e045d3305dd8ab81311fd2d003d03ae43a
Gerrit-Change-Number: 40141
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 04 Apr 2020 21:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment