Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55945 )
Change subject: drivers/intel/usb4/retimer: Update code to assign correct port number ......................................................................
Patch Set 9:
(4 comments)
File src/drivers/intel/usb4/retimer/chip.h:
https://review.coreboot.org/c/coreboot/+/55945/comment/2e16e88a_a21fb61e PS3, Line 17: /* _PLD setting */ : struct acpi_pld_group group;
This isn't necessary, it can be retrieved from the typec_port as well, see below
Done
https://review.coreboot.org/c/coreboot/+/55945/comment/4cacca09_5d1ebb00 PS3, Line 17: /* _PLD setting */ : struct acpi_pld_group group;
This isn't required anymore since it can be derived from the typec_port device?
Ack
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/55945/comment/f35f48fc_66b7e166 PS3, Line 364: usb_port = config->dfp[dfp_port].typec_port->path.usb.port_id;
should probably ensure that the device has the correct type first, e.g.: […]
Done
https://review.coreboot.org/c/coreboot/+/55945/comment/47c03201_e1505620 PS3, Line 373: acpi_pld_fill_usb(&pld, UPC_TYPE_PROPRIETARY, &config->dfp[dfp_port].group); : pld.shape = PLD_SHAPE_OVAL; : pld.visible = 1; : acpigen_write_pld(&pld);
This can also be retrieved from the `typec_port` if you do the following: […]
Done