Attention is currently required from: Michał Kopeć, Michał Żygowski, Patrick Rudolph, Paul Menzel, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82555?usp=email )
Change subject: mb/qemu-{i440fx,q35}/rom_media.c: add code for writable flash ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82555/comment/cda0a9cf_dca5e395?usp... : PS3, Line 24: Tested by starting QEMU with firmware passed as '-drive if=pflash', : '-drive if=pflash,readonly=on' and '-bios'. When started with firmware : passed through '-device loader', coreboot complains about missing or : corrupted FMAP, but this is the same behavior as without this change.
Maybe mention the new debug log that got printed?
Added
https://review.coreboot.org/c/coreboot/+/82555/comment/9dcab72b_fd01e6c3?usp... : PS3, Line 28:
Is a specific QEMU version needed?
From what I can tell it should work in all publicly available QEMU versions. Original support was added long time ago (~17y), and other than some bug and style fixes, it was mostly unchanged.
File src/mainboard/emulation/qemu-i440fx/rom_media.c:
https://review.coreboot.org/c/coreboot/+/82555/comment/5502a4d1_ad8ffc5e?usp... : PS3, Line 31: to write to the log
Is that only CBMEM log, or also serial and other log types?
Flash based event log only, the one enabled with CONFIG_ELOG. I've reworded this a bit, hopefully it is a bit clearer now.