Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47340 )
Change subject: src/soc/intel/denverton_ns: Use improvement in coreboot since 4.9
......................................................................
Patch Set 3: Code-Review+1
There are issues with setting NEM on Denverton platform reliable.
FSP-CAR works correctly and reliable so it the suggested method to setup CAR.
NEM could be removed in the future.
The same for serial legacy/io mode - There is no easy way to make it 100% legacy.
So I`m thinking about removing it and leave only serial mem mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc5ce91118c6052af23642fb3461f574cd888dea
Gerrit-Change-Number: 47340
Gerrit-PatchSet: 3
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 18:34:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment