Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31373 )
Change subject: vendorcode/amd/pi: Add merlinfalcon AGESA support ......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
https://review.coreboot.org/#/c/31373/3/src/vendorcode/amd/pi/00670F00/binar... File src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc:
https://review.coreboot.org/#/c/31373/3/src/vendorcode/amd/pi/00670F00/binar... PS3, Line 1159:
This should not be squashed here. We have separate patch: […]
Agree, I'll align with your code.
https://review.coreboot.org/#/c/31373/3/src/vendorcode/amd/pi/Kconfig File src/vendorcode/amd/pi/Kconfig:
https://review.coreboot.org/#/c/31373/3/src/vendorcode/amd/pi/Kconfig@37 PS3, Line 37: default "src/vendorcode/amd/pi/00670F00" if SOC_AMD_STONEYRIDGE_FT4
I dont' really approve the 3x 00670f00/ but I doubt that you will clean it. […]
Unfortunately it's not so easy. There are older projects using Carrizo using a different stile (separate south and north bridges) that requires 00660F01 and must be maintained. What I'm saying is that when you adopt a SOC style for Carrizo (Merlin Falcon), you must use 00670F00.