Attention is currently required from: Maximilian Brune.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73487 )
Change subject: util/ifdtool: Add option to create FMAP template ......................................................................
Patch Set 9:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/73487/comment/54db8d17_c1637ed8 PS7, Line 941: -p $(CONFIG_IFD_CHIPSET) According to ifdtool's integrated help, -p is used to handle platform-specific quirks. Do you mean that generic platforms having IFD but without quirks do not need to generate FMAP template? Is the logic below better?
``` DEFAULT_FLASHMAP:=$(top)/util/cbfstool/default-x86.fmd ifeq ($(CONFIG_HAVE_IFD_BIN),y) DEFAULT_FLASHMAP:=$(obj)/fmap-template.fmd $(DEFAULT_FLASHMAP): $(call strip_quotes,$(CONFIG_IFD_BIN_PATH)) $(IFDTOOL) # check if IFD_CHIPSET is set to indicate quirks ifneq ($(CONFIG_IFD_CHIPSET),) echo " IFDTOOL -p $(CONFIG_IFD_CHIPSET) -F $@ $<" $(IFDTOOL) -p $(CONFIG_IFD_CHIPSET) -F $@ $< else echo " IFDTOOL -F $@ $<" $(IFDTOOL) -F $@ $< endif # ifneq($(CONFIG_IFD_CHIPSET),) endif # ifeq($(CONFIG_HAVE_IFD_BIN),y) ```