Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36459 )
Change subject: soc/intel/{cnl,icl,skl}: Move ipu.asl into common/block/acpi
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Looks good
https://review.coreboot.org/c/coreboot/+/36459/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/ipu.asl:
https://review.coreboot.org/c/coreboot/+/36459/5/src/soc/intel/common/block/...
PS5, Line 21: Name (_CCA, ZERO)
Cache Coherency Attribute -- specifies whether a device and its descendants support hardware […]
Ack, thanks for checking.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d18571008c199fd5c3dbeed8cba9374520359b4
Gerrit-Change-Number: 36459
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Oct 2019 15:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment