Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 16:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 571: HOST_RESET_ONLY
CSE_RESET_ONLY
Done
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 573: send_heci_global_reset_req_message
not sure I understood, if the API is termed for global reset , then why are we accepting reset type […]
The function named after HECI command GLOBAL RESET REQUEST
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 573: u8
uint8_t, to be consistent with usage in the file.
Done
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 577: u8 group_id; : u8 command; : u8 reserved; : u8 result; : } __packed reply; : struct reset_message { : u8 group_id; : u8 cmd; : u8 reserved; : u8 result; : u8 req_origin; : u8 reset_type;
same? Just to align with usage in file or it will be a mixed bag
Done
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 598: (rst_type == GLOBAL_RESET)
braces can go.
Can you be clear on your comment? thanks
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 617: GBL RST
Global Reset to be more clear
Done
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 110: HOST_RESET_ONLY
CSE_RESET_ONLY?
Done