Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/antiroll... File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/antiroll... PS4, Line 62: recovery hash
comment needs update here and for the functions below.
Done
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/antiroll... PS4, Line 63: antirollback_read_space_hash
Probably add _mrc_ in the name to make it clear that these functions deal with hash of MRC data. […]
Done
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/mrc_cach... File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/mrc_cach... PS4, Line 41: recovery
Comment will need update.
Done
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/secdata_... PS4, Line 173: HASH_NV_SIZE,
nit: does this not fit on the previous line?
Moved up.