[coreboot-gerrit] Change in coreboot[master]: hatch: automate creating a new variant in coreboot

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )

Change subject: hatch: automate creating a new variant in coreboot
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
File util/mainboard/google/hatch/create_coreboot_variant.sh:

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
PS13, Line 54: # Start a branch. Use YMD timestamp to avoid collisions.
             : DATE=$(date +%Y%m%d)
             : repo start "create_${variant}_${DATE}"
> The goal is to have the scripts do all of the basic work to clone a baseboard into a new variant's n […]

Ok, I guess i'd let the user do all the git work, but that's just my own preference.

If you are doing the git work for them, why not do a git fetch and checkout origin/master as well?

You might want to print their previous head in case they weren't on a branch, and lose their position.