Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata... PS10, Line 171: } else { This part should probably also go to the next patch.
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata... PS10, Line 246: static uint32_t set_mrc_hash_space(uint32_t index, const uint8_t *data) Since you now already restricted this to TPM2 in the last patch, you could also just take out all of this stuff from the TPM1 parts and just move the toplevel API entry points into the TPM2 block.