Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, agogo.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )
Change subject: soc/mediatek/mt8196: Initialize MCUPM ......................................................................
Patch Set 6: Code-Review+2
(4 comments)
File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:
https://review.coreboot.org/c/coreboot/+/85888/comment/6254d28d_048de9c2?usp... : PS6, Line 56: MCUPM_SRAM_SIZE
I’d append _KB.
No, the unite is byte.
https://review.coreboot.org/c/coreboot/+/85888/comment/63a12697_a317b708?usp... : PS6, Line 69: POLLING_MCU_TIME
Please append the unit to the name.
@jarried.lin@mediatek.com Please use TIMES or COUNTS
File src/soc/mediatek/mt8196/mcupm.c:
https://review.coreboot.org/c/coreboot/+/85888/comment/dbb3c034_8dad378c?usp... : PS6, Line 17: POLLING_MCU_TIME
retry takes number of attempts as first argument. […]
No, the usage is correct.
https://review.coreboot.org/c/coreboot/+/85888/comment/9efd420f_ec2244c8?usp... : PS6, Line 21: "[EB_SPMC] Polling MCU_PORT_SET_R0_0 timeout, %#x\n",
Please also print the timeout value.
I don't think that is necessary. When the code jumps into this error, that mean it exceeds the attempts.