Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 1:
(7 comments)
File src/soc/intel/alderlake/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/01248599_6f4d12af PS1, Line 20: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/b8a8baeb_4f84962a PS1, Line 23: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", i, ec_port); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/8e871d51_d63a75c7 PS1, Line 23: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", i, ec_port); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/9b469054_c66ccff2 PS1, Line 28: ec_port++; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/1c1e9125_d618691a PS1, Line 28: ec_port++; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/cf0ccd95_e73e991d PS1, Line 28: ec_port++; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134327): https://review.coreboot.org/c/coreboot/+/59666/comment/521a7af9_3c218723 PS1, Line 32: die("Couldn't find correct port mapping or Invalid input port \n"); unnecessary whitespace before a quoted newline