[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add option to enable display over PCI external GFX

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )

Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... 
File src/soc/intel/icelake/Kconfig:

PS9:
> Thank you for the explanation. In my opinion VGA_ROM_RUN should imply `ALWAYS_RUN_OPROM`. […]

its selecting ALWAYS_RUN_OPROM but not selecting ALWAYS_RUN_OPROM sas i remember last while debugging

https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... 
PS9, Line 216: 	select FRAMEBUFFER_SET_VESA_MODE
> Sorry, for being unclear. I meant `FRAMEBUFFER_SET_VESA_MODE` specifically.

Its because with depthcharge pre os screen it needs GFX framebuffer in VESA mode to dump bmlblk image